xboxscene.org forums

Author Topic: Flatten Hierarchy Performance With Default.xbe  (Read 49 times)

tslayer

  • Archived User
  • Sr. Member
  • *
  • Posts: 499
Flatten Hierarchy Performance With Default.xbe
« on: September 27, 2003, 01:26:00 PM »

I was just wonderng if I should file a bug report, or perhaps an enhancement request, for how flatten hierarchy works when only displaying default.xbe.

Basically, if you have a folder with lots of files, the time it takes to display the folder when "Flatten my programs Hierarchy" and "Only show default apps" is marked takes a long time.

I think the performance can be improved if, instead of xbmp checking each file in a folder, it can just look directly for default.xbe.

Currently, if I am not mistaken, each file in a folder goes through a filter in UApplications.cpp and in there is where it determines whether to display the file or not.  So, when the two options are checked, and we only want to display the default.xbe, it still enumerates each file in the folder instead of directly trying for default.xbe.

If any of the mods feel I should file a bug report against this on sourceforge, please let me know and I'll go ahead and do that.

Thanks,

TS
Logged

tslayer

  • Archived User
  • Sr. Member
  • *
  • Posts: 499
Flatten Hierarchy Performance With Default.xbe
« Reply #1 on: September 27, 2003, 04:18:00 PM »

I'd actually like to elaborate on this some more after looking through the source code some more.

It looks like this performance issue is there even when these two options are disabled.

The Filter() in Catalogue.cpp is called regardless of the two settings which also means OnItemFilter in Uapplications.cpp gets called on each file because of the filterCallback.

So, the real issue here may just be that the Filter() in Catalogue.cpp may need to be improved because anytime we have a directory with lots of files in it, and a filter call back is required, we are going to see this slow performance.

This includes MP3s(which would probably be most common).  I have read of people having this problem with MP3s and now have figured out why and it makes sense that they can work around this by having multiple directories such that they have smaller amounts MP3s per directory.

Unfortanately, this can't be done for let's say Games on your HD that you want to use as Programs.  For example, ESPN NHL Hockey has lots of files in the directory and bringing up this directory takes a few minutes.

Anyhow, just wanted to provide my analysis of why this is occurring.

Thanks,

TS


Logged